Rename multiple keys to another name

[samueljoli]

Context

• node version: 6
• joi version: 10.3.x
• environment (node, browser):
• used with (hapi, standalone, ...):
• any other relevant information:

What are you trying to achieve or the steps to reproduce ?

const caseInsensitiveOverrides = ['marketcode', 'MarketCode', 'MARKETCODE'];

const schema = Joi.object({
  marketCode  : Joi.string(),
}).rename(caseInsensitiveOverrides, 'marketCode')

I have a need for my params to be case insensitive and would like to implement that by using the rename api. It would be nice if I could pass rename a list of keys that whenever present would rename to a default key.

Example:
=> /route?marketCode=191
=> /route?marketcode=191
=> /route?MARKETCODE=191

I would expect each permutation to be validated and that in my handler the return value would be...

request.query.marketCode // => 191

[DavidTPate]

@samueljoli this seems like a poor use of the Joi.rename() functionality. When dealing with objects we have the Joi.object().pattern() construct to use for cases like this.

The reason why I think it is a bad usage is that you would be going through and needing to support every form of case for your string (I think that would be what 2^10 possibilities?) which is going to make this quite slow. Instead I would use the Joi.object().pattern() to accomplish this with a simple RegExp.

const schema = Joi.object().pattern(/^marketcode$/i, Joi.string());

[Marsup]

Thought the same thing, except that regexp should be anchored (ie. /^marketcode$/i).

[samueljoli]

@Marsup @DavidTPate Thanks I wasn't sure about the best way going about it.

@DavidTPate Whether I used pattern or rename wouldn't I have to account for every case of that string?

Also the only problem with using regex is that while it will validate the param it doesn't address my need to be able to still reference the value of that param in it's default camel case form. Using regex would also mean that I would have to make a check for each case (ex request.query.marketcode || request.query.marketCode || etc...). That's the main reason why I thought rename was the perfect candidate. It's not just about validation but being able to reference it in my src in the expected form.

[Marsup]

I'm going to set this issue as a request, taking in a regexp as the source of the rename could make sense indeed.

[samueljoli]

@Marsup Sweet! I'll look into implementation.

[Marsup]

This looks a bit complicated for someone not familiar with joi's code, but feel free to try :)

[samueljoli]

@Marsup Is there anything in place for me to get a high level walk through the code base? Otherwise I know a core contributor who I can bug to onboard me.

[WesTyler]

(just kidding ;) happy to walk through joi code with you)

[samueljoli]

@WesTyler 😈 hehehe looking forward to bugging you 🐛