-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump joi to node 8+ #1327
Comments
Hi there, was just discussing this in IcedFrisby/IcedFrisby#80. Am I understanding correctly that joi is no longer supporting Node 6? While I appreciate the desire to stay current, it seems early to discontinue support for Node 6. Many projects where I'm using IcedFrisby + Joi are using Node 6, which is still in active LTS through April. https://github.com/nodejs/Release Thoughts? |
@paulmelnikow you should read the release notes first. |
Ah thanks, I see them now: #1328. I missed them before because they're not referenced in the commit history. I'm still not completely clear about Node 6. Does "Use node.js v8 as baseline" mean support for Node 6 is discontinued in 13.x? Is there a definition somewhere of the baseline hapi.js decision mentioned in the notes? I couldn't find more information about that. |
The entire hapi ecosystem is moving to use async/await. That's node v8. |
Makes sense. I've been wanting to make Joi an optional or peer dependency of IcedFrisby and this is a good reason to do that. That way projects using Node 8 can stay up to date, and projects using Node 6 can use 12.x. |
Joi being what it is in the hapi.js galaxy, I'm delaying the nuclear option to transpile joi 13+ to node 4-6 until this is really needed or I don't have the resources to support 12+13 anymore. Of course this would come with no guarantee except trusting babel to do the right thing. |
How do we use const match = await joi.validate(values, schema)
// the above throws an error, `TypeError: Method Promise.prototype.then called on incompatible receiver #<Promise>`
const match = joi.validate(values, schema)
// the above returns an object with `value`, `then` and `catch` keys. `value` is a Promise, but seems empty. EDIT: Looks like this may only happen with babel. |
No description provided.
The text was updated successfully, but these errors were encountered: