Validate port numbers

[sholladay]

I have this in a few places...

joi.validate(option, {
    port : joi.number().integer().min(0).max(65535)
});

Given that joi is most commonly used for servers (related: string().hostname()) and port numbers are a standardized and commonly used thing, I would prefer for this to be built in.

joi.validate(option, {
    port : joi.number().port()
});

Beyond the readability and succinctness of it, I like that this would free my apps from having the 65535 constant, which people sometimes ask me about.

Thoughts?

[WesTyler]

My first thought is that this would make a better extension than addition to the core api. I honestly don't know why I think that, but there you have it. :P

[Marsup]

I don't think we have anything resembling the wrapping of other existing primitives, not sure I feel good about it either.

[sholladay]

By "wrapping other primitives", do you mean higher-level abstractions? joi has plenty of these. In fact, number.positive(), used in this very example, is one of them.

[robertkeizer]

The hostname specification is defined ( Let's just use RFC 1035 link ) as an abstraction of certain characters and formatting.

An example being that there is a maximum length of 255 octects ( let's just call them characters because they're limited to that space ).

This is reflected ( good ) in Joi:

Joi.validate( { hostname: "fooasldfkjasldkfjasldkfjlasdjflsadjflasjdflkasjdflasjdlfsdlkjfalsdfjalsfjlasdkfjlasdjfalsfjlasfjlaskdfjlasdkfjlaskdjflaskdjflaskdjflsakjfdlaskfjlsakdfjlasdkjflasdkfjalskdfjlsakdfjlaskdjflaskdjflsakdfjbaronetwofoobarasdfkjadlfajlfkajsdflkdajsfldasjflkasjdflaksjflasjflsakjflaskdjflaskdjflasdjflaskdfjlaskdfjlaskfjlasjdflkasdjflaskjdflaskdjflasdkjfalsdjflaskjdflaskjdflasjdflakdsfj" }, s, function( err, result ){ if( err ){ console.log( "invalid" ); } else{ console.log( "valid" ); } } );

// ( output is 'invalid' )

Why would port numbers not also be included, if they are also limited by an RFC ( and industry standard )?

I'm all for keeping the core fairly small, but if you're including hostname, I feel port would also be appropriate.

[Marsup]

Can someone submit a PR then?

[mrveera]

Hey @Marsup, I added this feature and I got it work, but before submitting PR I already added some other code to my master branch. If it's cleared I can submit PR for this feature also. Otherwise, If you agree I'll add this feature code to other branch and I'll submit PR.

[sholladay]

That would be fantastic, @veera83372. Thanks for taking the time.