joi.ref doesn't work properly with max() function for dependant dates

[jeurrutia]

Context

• node version: 8.9.0
• joi version: 10.6.0
• environment (node, browser): node
• used with (hapi, standalone, ...): hapi

What are you trying to achieve or the steps to reproduce ?

When trying to do the validation from a date dependant for another one and using joi.ref(...) an error related to a bad example occurs.

Here the code snippet to reproduce the problem:

server.route({
     method: 'GET',
     path: 'foo',
     handler: (request, reply) => reply('OK'),
      config: {
        validate: {
          query: joi.object({           
            fromDate: joi.date()
              .iso()
              .required()
              .max(joi.ref('toDate'))             
              .example(new Date('2017-10-25T00:00:00.000Z')),
            toDate: joi.date()
              .iso()
              .default(() => new Date(), 'Now')
              .max('now')
              .example(new Date('2017-10-28T00:00:00.000Z')),
          }).unknown(),        
        },
      },
    });

Which result you had ?

error: {
      "message": "Bad example: \"value\" references \"toDate\" which is not a date",
      "name": "Error",
...
}

What did you expect ?

Return json data expected for this API.

[WesTyler]

Confirmed this in Joi@13.0.1 as well.

[WesTyler]

Interesting, so it's not actually the ref in the .max(). It's .example().

If you remove .example() from the "fromDate" child the schema compiles fine. And actually, I think if you just rearrange the order so that .example is called before .max it will also work.

joi.object({           
            fromDate: joi.date()
              .iso()
              .required()             
              .example(new Date('2017-10-25T00:00:00.000Z'))
              .max(joi.ref('toDate')),
            toDate: joi.date()
              .iso()
              .default(() => new Date(), 'Now')
              .max('now')
              .example(new Date('2017-10-28T00:00:00.000Z')),
          }).unknown()

[WesTyler]

Oh yeah, we've seen this before but with .min. See the discussion here.

Since the "fix" would be rather involved, there is nothing really left that's actionable here. I am going to bump the discussion issue on the underlying issue over here though.

[WesTyler]

This actually should be resolved in v13.0.2. I'm going to close this out. Let me know if you see any additional issues and I can re-open if needed.