Add an separator parameter to Joi.reach

[pierreis]

Currently, the separator of Joi.reach is fixed as a dot. This might not be a good choices for for use cases where object keys are e-mails or URLs, causing the method not to behave as expected.

I would suggest adding a third parameter separator to that method, allowing to be user-configured. For example, slashes can make sense for compatibility with JSON patch. The default would remain a dot for compatibility.

[DavidTPate]

@pierreis We're always glad to take a look at PRs and do our best to get them merged, if this is something you'd like to see I'd suggesting giving it a stab in a PR.

I would suggest utilizing an options object as the third parameter as there might be some other options that are desired in the future and I would rather see an object for options as opposed more and more parameters.

As an example, Hoek.reach() supports a number of parameters and you can see the relevant code here.

[Marsup]

I'd rather take an array directly instead of adding new options.

[pierreis]

That would solve the issue, indeed.
Considering in that case the current defaults (splitting with a dot separator) for backward compatibility.

[DavidTPate]

Makes sense to me.

[mrveera]

@Marsup, I am ready to solve this issue by adding separator parameter to reach function

[Marsup]

I wrote a few posts above that I don't want this parameter, but you're free to do a PR following those instructions. Please ask if it's not clear.

[vijaykrishnavanshi]

Hi @Marsup, just to make sure that I am understanding the issue.
You mean array in the path param right?

[Marsup]

Correct, a pre-split array instead of the current path.