Continue array validation even if items() fails

[Thomas--S]

Hello, I stumbled accross the following behavior using the joi version provided by npm:

When I set abortEarly: false, no unique error is returned if there is a previous error, e.g. from required.

Example:

console.log(Joi.validate([
    {
        test: 'test',
        hello: 'world',
    },
    {
        test: 'test',
    }
], Joi.array().items(Joi.object().keys({
    test: Joi.string(),
    hello: Joi.string(),
})).unique('test'), {abortEarly: false}).error.details);

This outputs the following as expected:

[ { message: '"value" position 1 contains a duplicate value',
    path: [ 1 ],
    type: 'array.unique',
    context:
     { pos: 1,
       value: [Object],
       dupePos: 0,
       dupeValue: [Object],
       path: 'test',
       key: 1,
       label: 'value' } } ]

---

However:

console.log(Joi.validate([
    {
        test: 'test',
        hello: 'world',
    },
    {
        test: 'test',
    }
], Joi.array().items(Joi.object().keys({
    test: Joi.string(),
    hello: Joi.string().required(),
})).unique('test'), {abortEarly: false}).error.details);

only outputs the following

[ { message: '"hello" is required',
    path: [ 1, 'hello' ],
    type: 'any.required',
    context: { key: 'hello', label: 'hello' } } ]

I'd expect the two errors to be returned in the second example. I'm not sure if this is a bug.

Thanks in advance for your efforts!

[WesTyler]

Yeah, I did confirm that if an "included" item in the .items() option fails validation it will not continue on to the additional array checks even with abortEarly: false. This is because the .items() options are validated during the base type validation rather than during the additional option tests.

Consider Joi.string().guid().validate(12345). The base type validation fails on the number input, so Joi doesn't bother continuing to check the string-specific options beyond that even if you specify abortEarly: false.

This array example is the same as the above string example. An item failure in .items() will prevent any additional checks from being run at all. I would consider this a bug, but since it has been this way for as long as it has, I'll leave it to @Marsup to determine if it's a wont fix or not. If he doesn't have a specific reason that .items() validation needs to be run as part of the base rules, we can fix this.