Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace isemail with @hapi/address #1776

Closed
hueniverse opened this issue Apr 2, 2019 · 1 comment
Closed

Replace isemail with @hapi/address #1776

hueniverse opened this issue Apr 2, 2019 · 1 comment
Assignees
@hueniverse
Labels
breaking changes Change that can breaking existing code dependency Update module dependency release notes Major release documentation
Milestone
15.0.0

Comments

@hueniverse
Copy link
Contributor

hueniverse commented Apr 2, 2019 •
edited
Loading

Breaking changes:

Joi.string().email() options changed. The following options are no longer supported:

  • checkDNS (remains unsupported)
  • errorLevel - unsupported with no replacement. The new validation rules treat quoted-strings, comments, obsolete formats, and domain literals as errors.
  • minDomainAtoms - use minDomainSegments.
  • tldBlacklist - use tlds.deny instead.
  • tldWhitelist - use tlds.allow instead.

Checklist

  • Scan you code for any reference to email( and check if options are passed. If they are, convert them to use the new options as described above.
  • Ensure you understand that some email addresses considered valid before are no longer valid (specifically those with quoted strings "first last"@example.com and domain literals test@[127.0.0.1]).
@hueniverse hueniverse added the breaking changes Change that can breaking existing code label Apr 2, 2019
@hueniverse hueniverse added this to the 14.4.1 milestone Apr 2, 2019
@hueniverse hueniverse self-assigned this Apr 2, 2019
@hueniverse hueniverse added the dependency Update module dependency label Apr 2, 2019
hueniverse added a commit that referenced this issue Apr 2, 2019
@hueniverse
Repalce isemail with address. Closes #1776
7e172c1
@hueniverse hueniverse added the release notes Major release documentation label May 1, 2019
@hueniverse hueniverse mentioned this issue May 1, 2019
Closed
@millette millette mentioned this issue May 19, 2019
Closed
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hueniverse hueniverse

Labels
breaking changes Change that can breaking existing code dependency Update module dependency release notes Major release documentation
Projects
None yet
Milestone
15.0.0
Development

No branches or pull requests
1 participant
@hueniverse