Joi.string().uri() accepts 'http:/' as valid URL

[paulmelnikow]

Describe the problem you are trying to fix (provide as much context as possible)

I want to reject 'http:/' as an invalid URL

const Joi = require('@hapi/joi')
Joi.validate('http:/', Joi.string().uri())

This does not raise an error. What I expect is:

ValidationError: "value" must be a valid uri

There was a similar report in #1732 for http:// (with two slashes) which was addressed in d7ff4fa. However, that code still accepts http:/ (with one slash).

Which API (or modification of the current API) do you suggest to solve that problem ?

Modify the URI regex generator to reject this case.

Are you ready to work on a pull request if your suggestion is accepted ?

I got as far as writing a test case, though I wasn't sure how to modify the regex generator to solve this.

[hueniverse]

Solving this through the regex would be a nightmare since it is technically valid. Instead, I special cased it.

[paulmelnikow]

Thank you!

[jimmywarting]

I found out that one could use the URL constructor in node to use the same constraint validation that exist in html forms and v8.

 var url = 'http:/'
 var valid = false
 try {
   new URL(url)
   valid = true
 } catch(err) {}

console.log(valid) // false

 var url = 'protocol:/'
 var valid = false
 try {
   new URL(url)
   valid = true
 } catch(err) {}

console.log(valid) // true

far more easier than some regex validation i think
and it handles both cases correctly with http:/ and foo:/