Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giving an array argument to any.allow(...values) gives incorrect error #2187

Closed
ChrisCrewdson opened this issue Oct 17, 2019 · 1 comment
Closed
Assignees
Labels
bug Bug or defect
Milestone

Comments

@ChrisCrewdson
Copy link

Support plan

  • which support plan is this issue covered by? (e.g. Community, Core, Plus, or Enterprise): Community
  • is this issue currently blocking your project? (yes/no): no
  • is this issue affecting a production system? (yes/no): no

Context

  • node version: 10.16.3
  • module version with issue: 16.1.7
  • last module version without issue: 15.1.1
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): hapi
  • any other relevant information:

What are you trying to achieve or the steps to reproduce?

const joi = require('@hapi/joi')

const example = joi.string().allow(['', null]);
example.validate('bar');

// Error: Method no longer accepts array arguments: valid

What was the result you got?

An exception was thrown with the message "Method no longer accepts array arguments: valid"

What result did you expect?

An exception thrown with the message "Method no longer accepts array arguments: allow"

@ChrisCrewdson ChrisCrewdson added the support Questions, discussions, and general support label Oct 17, 2019
@hueniverse hueniverse self-assigned this Oct 17, 2019
@hueniverse hueniverse added bug Bug or defect and removed support Questions, discussions, and general support labels Oct 17, 2019
@hueniverse
Copy link
Contributor

Seems reasonable.

@hueniverse hueniverse added this to the 16.1.8 milestone Nov 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug or defect
Projects
None yet
Development

No branches or pull requests

2 participants