Joi.string().domain() treats an email address as a valid domain name

[PallasKatze]

Support plan

• which support plan is this issue covered by? (e.g. Community, Core, Plus, or Enterprise): Community
• is this issue currently blocking your project? (yes/no): yes
• is this issue affecting a production system? (yes/no): no

Context

• node version: 10.15.3
• module version with issue: 16.1.7
• last module version without issue: -
• environment (e.g. node, browser, native): node
• used with (e.g. hapi application, another framework, standalone, ...): standalone
• any other relevant information: -

What are you trying to achieve or the steps to reproduce?

Joi.assert('mail@example.com', Joi.string().domain().required());

What was the result you got?

The line of code above does not throw any exception

What result did you expect?

I expect it to throw ValidationError because the input is an email address, not a domain name.

[yoavke]

I wouldn't expect domain to throw an error on an Email address, since it's also under the definition of a "Domain".
I'd use string().uri() (https://hapi.dev/family/joi/?v=16.1.7#stringurioptions) instead.

Every email address describes a domain, but it works only in this direction.

[PallasKatze]

I wouldn't expect domain to throw an error on an Email address, since it's also under the definition of a "Domain".

A domain name is just a part of an email address. It also a part of URI but URI is not a valid input for .domain(). So I think that the name of this method is deceptive or the method is broken by itself.

I'd use string().uri() (https://hapi.dev/family/joi/?v=16.1.7#stringurioptions) instead.

This require the input string to be an URI, it fails on valid domain names.

[hueniverse]

Fixed via hapijs/address#19