Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for older Node versions maybe lost in v17.8 #2914

Closed
robatwilliams opened this issue Feb 20, 2023 · 3 comments
Closed

Support for older Node versions maybe lost in v17.8 #2914

robatwilliams opened this issue Feb 20, 2023 · 3 comments
Assignees
Labels
support Questions, discussions, and general support
Milestone

Comments

@robatwilliams
Copy link

Support plan

  • is this issue currently blocking your project? (yes/no): no
  • is this issue affecting a production system? (yes/no): no

Context

  • node version: v12.22.12
  • module version with issue: v17.8.1
  • last module version without issue: v17.7.1 probably
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): https://github.com/jeffbski/wait-on
  • any other relevant information: I'm not condoning use of Node 12, which is past its end of life. This broke an old CI job which was using Node 12. Rather, reporting this due to loss of stated Node versions support (and in a minor increment too).

What are you trying to achieve or the steps to reproduce?

I'm not using joi directly, but via wait-on. From what I can see, the release 17.8 bumped some dependencies to versions that don't claim to support Node 12 (https://hapi.dev/resources/status/).

Having investigated the cause chain myself, I wanted to report this to you rather than let the maintainer of wait-on do it themselves, to avoid repeated work and possibly save other consumers from trouble.

What was the result you got?

Error jeffbski/wait-on#136 , which I believe may have been caused by bumping of joi's dependencies in the 17.8 release.

What result did you expect?

The package is compatible with Node 12, as stated on https://joi.dev/resources/status/#joi

@robatwilliams robatwilliams added the support Questions, discussions, and general support label Feb 20, 2023
@Marsup
Copy link
Collaborator

Marsup commented Feb 21, 2023

This is probably a documentation issue indeed, as stated in your original issue, node 12 has been EOL for more than 2 years and was bound to break. I'm not sure I see an easy way out.

@Marsup
Copy link
Collaborator

Marsup commented Feb 21, 2023

Actually, the breaking changes of 17.x mention dropping < 12, not < 14. Give me some time, I'll revert 17.8.x and do a clean 18. Apologies.

@Marsup Marsup added this to the 17.8.3 milestone Feb 21, 2023
@Marsup Marsup self-assigned this Feb 21, 2023
@Marsup
Copy link
Collaborator

Marsup commented Feb 21, 2023

Everything should be back to normal, I'll do 18.x later. Sorry again for the troubles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support Questions, discussions, and general support
Projects
None yet
Development

No branches or pull requests

2 participants