array.unique doesn't validate duplicate dates

[gaastonsr]

Should not array.includes(Joi.date()).unique() validate duplicate dates?

[Marsup]

Like said in the documentation, only literals work currently, but looks like a bug to me.

[Marsup]

@hueniverse mind if I change that behavior ? Tests seem to explicitly deny that, was it for a reason ?

[hueniverse]

The test confirms the docs. It was set this way to avoid expensive deep comparisons of objects. Whatever the change, it needs to perform well and to be well defined. Does unique means identical references or deep equality?

[Marsup]

I was going for deep equality. This needs to be made explicit that there will be a performance penalty on objects indeed.

[hueniverse]

Hoek has utils for deep comparisons now.

[Marsup]

Yes, already did the code with that, just needs tests now.

[gaastonsr]

Cool. Thanks.