Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multipleOf method for Number? #532

Closed
a00andos opened this issue Jan 19, 2015 · 4 comments
Closed

multipleOf method for Number? #532

a00andos opened this issue Jan 19, 2015 · 4 comments
Assignees
Labels
feature New functionality or improvement
Milestone

Comments

@a00andos
Copy link

What do you say about creating a "multipleOf" method for Numbers in Joi? (According to its definition in JSON schema: http://json-schema.org/latest/json-schema-validation.html#anchor14).

At least it would be useful to me! =)

@a00andos a00andos changed the title Integration of multipleOf on Number? multipleOf method for Number? Jan 19, 2015
@Marsup Marsup added the request label Jan 19, 2015
@Marsup Marsup self-assigned this Jan 19, 2015
@Marsup
Copy link
Collaborator

Marsup commented Jan 19, 2015

I'll accept a PR with multiple.

@a00andos
Copy link
Author

I'm not that into the jargong and praxis of Github, but does: "I'll accept a PR with multiple." means: If you(a00andos) want you can create a Pull Request, where you(a00andos) take it up on yourself to create the code of the request above, and if I(Marsup) like what you have done, I'll merge it into Joi?

Hope you dont mind the newbie clarification =)

@Marsup
Copy link
Collaborator

Marsup commented Jan 20, 2015

That's exactly what I'm saying :)
This should be an easy task, you can inspire from other lookalike rules, tests should be pretty similar as well.
Happy to help if you're lost.

@Marsup Marsup added this to the 6.0 milestone Feb 4, 2015
@Marsup Marsup closed this as completed Feb 4, 2015
@hueniverse hueniverse added feature New functionality or improvement and removed request labels Sep 19, 2019
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New functionality or improvement
Projects
None yet
Development

No branches or pull requests

3 participants