-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email validation doesn't allow emails which are compliant with RFC 6530 #931
Comments
This should probably be brought up in https://github.com/hapijs/isemail, but leave this one opened so I can trace it. |
Hadn't noticed, this has already been raised here: skeggse/isemail#17 |
Ha, sorry for misdirecting you :) |
|
Oh funny, I'd never seen this issue. Interesting idea with the |
As far as I understand, both RFCs will be enabled once I release the next joi version, but this request still stands as it could be interesting to be able to pick and choose whether internationalized emails should be allowed. I think this again falls onto |
why is that? |
Because user constraints. There are 2 RFCs, I can imagine systems not being ready to accept both. |
I've definitely run into this in the past. A simple thing for this might be you use DynamoDB to store email addresses which doesn't support the full set of internationalized characters (without escaping them) so you want to ensure that you have only valid characters. |
Is this a requirement prior to releasing international email via isemail@3.x.x? |
I'd tend to say so, as joi would start accepting emails it didn't previously. |
This is an option in |
Guys, you can close this issue? Apparently is solved |
Has Joi updated to the latest isemail? |
It takes 3.x so I guess yes https://github.com/hapijs/joi/blob/master/package.json#L18 🚀 |
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Context
What are you trying to achieve or the steps to reproduce ?
Note that this email is considered invalid, which is correct, but permitted by https://tools.ietf.org/html/rfc6530
Which result you had ?
Email address was marked as invalid. This is a problem as I would now have to use a regexp or simple string validation for email addresses which significantly reduces readability.
What did you expect ?
I'd hope for some method of switching between RFC versions - perhaps by passing in the rfc number. I don't really have any other 'good solutions' for this.
Google, for example support sending and recieving from RFC 6530 emails, but not signing up with them - they would use something like:
Of course
compliance
could be changed tointernational
: true/false' or something similar, but I think compliance is more explicit.The text was updated successfully, but these errors were encountered: