Move time rules to an extension

[hueniverse]

I really REALLY wants to get rid of the moment dependency. My bet is that date validation is rarely used and we're all installing this gigantic module for no reason.

[AdriVanHoudt]

it is only used on this line

joi/lib/date.js

Line 91 in a646761

date = Moment(value, format, true);

so only moving out the format part is enough no?

[hueniverse]

Sure.

[Marsup]

Planning on it, although it's not very high on my list. What's the sudden need?

[paulovieira]

fecha might be an alternative. It's small and has no dependencies.

https://github.com/taylorhakes/fecha

Works well to parse a date in a string in some expected format. Example:

fecha.parse('10-12-10 14:15:16', 'YY-MM-DD HH:mm:ss');  // returns a Date object
fecha.parse('10-12-10 14:15', 'YY-MM-DD HH:mm:ss');  // returns false

[thebergamo]

fecha sounds a good alterantive.
@AdriVanHoudt moment is used in the line above too, to validate if the date is valid, using fecha you can supress this 2 lines in just one, because if the validation fails, its return false, so, just on ternary is wanted.

[DavidTPate]

The thing with moving over to something like fecha is that the current contract will be broken (so as long as that is noted and versioned appropriately that's fine). moment is large because it ships with a ton of locales while fecha requires you to define those locales for yourself.

[AdriVanHoudt]

I don't think replacing moment is a solution. Just remove this and make a plugin of it