Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Joi.validate options with removal of error #1010

Closed
wants to merge 2 commits into from
Closed

Update Joi.validate options with removal of error #1010

wants to merge 2 commits into from

Conversation

ptrckc
Copy link

@ptrckc ptrckc commented Oct 19, 2016

Context

  • joi version: 9.2.0

What are you trying to achieve or the steps to reproduce ?

Further updates for commit 8c48da5 and issue #874

ptrckc added 2 commits October 19, 2016 10:51
Fix schema based on commit 8c48da5 and issue #874
@Marsup
Copy link
Collaborator

Marsup commented Oct 19, 2016

This is actually a bug, I'd rather fix joi than the documentation :)

@ptrckc ptrckc closed this Oct 19, 2016
@Marsup Marsup added the non issue Issue is not a problem or requires changes label Oct 19, 2016
@Marsup Marsup self-assigned this Oct 19, 2016
@Marsup
Copy link
Collaborator

Marsup commented Oct 19, 2016

Really sorry for the hiccup, you were actually right the 1st time, apparently I'm not good at multi-tasking :)
Too bad you deleted the repo, I'll port that fix myself.

Marsup added a commit that referenced this pull request Oct 19, 2016
@Marsup
Copy link
Collaborator

Marsup commented Oct 19, 2016

It's now pushed, thanks a lot for the report @ptrckc.

@Marsup
Copy link
Collaborator

Marsup commented Oct 19, 2016

By the way, if you're looking for the replacement, it's mentioned in the release notes (#920).

@Marsup Marsup added this to the 10.0.0 milestone Nov 16, 2016
@Marsup Marsup added bug Bug or defect and removed non issue Issue is not a problem or requires changes labels Nov 16, 2016
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug or defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants