Added a string.base64() method. #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marsup
requested changes
Nov 3, 2016
| @@ -376,6 +376,20 @@ internals.String = class extends Any { | |||
| }); | |||
| } | |||
|
|
|||
| base64() { | |||
|
|
|||
| const regex = /^[a-z0-9\+\/]+(=+)?$/i; | |||
There was a problem hiding this comment.
This regex doesn't seem to be good enough, there are few provided in http://stackoverflow.com/questions/475074/regex-to-parse-or-validate-base64-data, https://github.com/kevva/base64-regex seems quite good, don't think he'd be offended if we took it from him.
There was a problem hiding this comment.
Oh cool, I'll switch that out and add in some more unit tests. I had a feeling there might be some weird paddings that could sneak through.
Marsup
approved these changes
Nov 6, 2016
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like string.hex() but for base64