Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending describe() to include renames in metadata #1027

Merged
merged 3 commits into from
Nov 6, 2016

Conversation

lamchakchan
Copy link
Contributor

@lamchakchan lamchakchan commented Nov 6, 2016

For the object.renames() API, it currently stores data within the scoping of schema._inner.renames. This set of schema definition is not projected within the any.describe() function. I'm adding this with the intent that renames() meta data can be part of a common contract. This will also help support felicity.

Please let me know of any concern with this implementation.

This is also a fix to Issue #1026

@WesTyler
Copy link
Contributor

WesTyler commented Nov 6, 2016

Thanks @lamchakchan ! :D
Relates to #1026

@Marsup Marsup added the feature New functionality or improvement label Nov 6, 2016
@Marsup Marsup self-assigned this Nov 6, 2016
@Marsup Marsup added this to the 10.0.0 milestone Nov 6, 2016
@Marsup Marsup merged commit 7581051 into hapijs:master Nov 6, 2016
@lamchakchan
Copy link
Contributor Author

Thank you for the quick pull @Marsup!

@lamchakchan lamchakchan deleted the extend_describe branch November 6, 2016 14:28
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New functionality or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants