Extending describe() to include renames in metadata#1027
Merged
Marsup merged 3 commits intohapijs:masterfrom Nov 6, 2016
Merged
Extending describe() to include renames in metadata#1027Marsup merged 3 commits intohapijs:masterfrom
Marsup merged 3 commits intohapijs:masterfrom
Conversation
Contributor
|
Thanks @lamchakchan ! :D |
Contributor
Author
|
Thank you for the quick pull @Marsup! |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the
object.renames()API, it currently stores data within the scoping ofschema._inner.renames. This set of schema definition is not projected within theany.describe()function. I'm adding this with the intent thatrenames()meta data can be part of a common contract. This will also help support felicity.Please let me know of any concern with this implementation.
This is also a fix to Issue #1026