allow param defaults to be set by the param validations

[kturney]

I found it surprising while making an extension that the defaults I set in the params validation weren't being applied.

[Marsup]

Good catch.

[Marsup]

Can you replace with arg = joi.attempt(arg, validateArgs) ?

[kturney]

Maybe you'd rather I use joi.attempt rather than joi.validate? Either way, it seems the "throws error when validations fails" branch wasn't being hit.

[Marsup]

What do you mean not being hit ? The coverage is still 100%.

[kturney]

I needed to add a few expects to cause the if (res.error) { throw res.error } branch to be hit, which is implicit with joi.assert and joi.attempt (unless I'm missing something).

[Marsup]

Ah ok, then you reached a better coverage, that's great.

[kturney]

Thanks for the quick turn around and all of your hard work! :-)

[Marsup]

It's published.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.