Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove empty flag if only reset is used #1266

Merged
merged 2 commits into from
Sep 20, 2017
Merged

remove empty flag if only reset is used #1266

merged 2 commits into from
Sep 20, 2017

Conversation

swarthy
Copy link
Contributor

@swarthy swarthy commented Aug 7, 2017

fix for #1249

WesTyler
WesTyler approved these changes Aug 9, 2017
View reviewed changes
Copy link
Contributor

@WesTyler WesTyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a stab at this! It looks good to me. Up to @Marsup if/when he wants to merge :)

@Marsup Marsup self-assigned this Sep 20, 2017
@Marsup Marsup added the bug Bug or defect label Sep 20, 2017
@Marsup Marsup merged commit 8389222 into hapijs:master Sep 20, 2017
@Marsup Marsup added this to the 11.0.3 milestone Sep 20, 2017
@Marsup Marsup mentioned this pull request Sep 20, 2017
Closed
@Marsup
Copy link
Collaborator

Marsup commented Sep 20, 2017

Thanks, it's released.

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
@swarthy swarthy deleted the fix1249 branch January 10, 2020 05:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WesTyler WesTyler WesTyler approved these changes

Assignees

@Marsup Marsup

Labels
bug Bug or defect
Projects
None yet
Milestone
11.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@swarthy @Marsup @WesTyler