Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string.normalize for unicode normalization #1291

Merged
merged 2 commits into from
Sep 20, 2017
Merged

Add string.normalize for unicode normalization #1291

merged 2 commits into from
Sep 20, 2017

Conversation

noinkling
Copy link
Contributor

@noinkling noinkling commented Sep 3, 2017 •
edited
Loading

Implements #1289, I did have some time after all 😄

@noinkling
Copy link
Contributor Author

noinkling commented Sep 15, 2017 •
edited
Loading

Rebased and updated the tests to make them compatible with commit 8565afc. Also refactored them so they're not reliant on callbacks being synchronous (was originally trying to avoid nesting, but I realized that's a bad idea, especially considering #1194).

@Marsup Marsup added the feature New functionality or improvement label Sep 15, 2017
@Marsup
Copy link
Collaborator

Marsup commented Sep 15, 2017

Thanks for keeping it up to date, now that 11 is done I'll try to get back to you asap on this.

@Marsup Marsup added this to the 11.1.0 milestone Sep 20, 2017
@Marsup Marsup self-assigned this Sep 20, 2017
@Marsup
Copy link
Collaborator

Marsup commented Sep 20, 2017

Flawless job, thank you !

@Marsup Marsup merged commit 2adcc09 into hapijs:master Sep 20, 2017
@Marsup Marsup mentioned this pull request Sep 20, 2017
Closed
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Marsup Marsup

Labels
feature New functionality or improvement
Projects
None yet
Milestone
11.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@noinkling @Marsup