New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string.normalize for unicode normalization #1291

Merged
merged 2 commits into from Sep 20, 2017

Conversation

Projects
None yet
2 participants
@noinkling
Contributor

noinkling commented Sep 3, 2017

Implements #1289, I did have some time after all 馃槃

@noinkling noinkling force-pushed the noinkling:normalize branch from 9345ee4 to a39af12 Sep 15, 2017

@noinkling

This comment has been minimized.

Contributor

noinkling commented Sep 15, 2017

Rebased and updated the tests to make them compatible with commit 8565afc. Also refactored them so they're not reliant on callbacks being synchronous (was originally trying to avoid nesting, but I realized that's a bad idea, especially considering #1194).

@Marsup Marsup added the enhancement label Sep 15, 2017

@Marsup

This comment has been minimized.

Member

Marsup commented Sep 15, 2017

Thanks for keeping it up to date, now that 11 is done I'll try to get back to you asap on this.

@Marsup Marsup added this to the 11.1.0 milestone Sep 20, 2017

@Marsup Marsup self-assigned this Sep 20, 2017

@Marsup

This comment has been minimized.

Member

Marsup commented Sep 20, 2017

Flawless job, thank you !

@Marsup Marsup merged commit 2adcc09 into hapijs:master Sep 20, 2017

3 checks passed

Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment