Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add promise-like API to validate. Fixes #1314. #1315

Merged
merged 1 commit into from
Sep 24, 2017
Merged

Add promise-like API to validate. Fixes #1314. #1315

merged 1 commit into from
Sep 24, 2017

Conversation

Marsup
Copy link
Collaborator

@Marsup Marsup commented Sep 24, 2017

Let me know if it fits your goals @hueniverse.

@Marsup Marsup added the feature New functionality or improvement label Sep 24, 2017
@Marsup Marsup added this to the 11.1.0 milestone Sep 24, 2017
@Marsup Marsup self-assigned this Sep 24, 2017
// or
const promise = Joi.validate(value, schema);
promise.then((value /* { "a" : 123 } */) => {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put the value example in the payload, not the arguments.

@hueniverse hueniverse merged commit 8b0d898 into master Sep 24, 2017
@hueniverse hueniverse deleted the promises branch September 24, 2017 17:15
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New functionality or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants