New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add promise-like API to validate. Fixes #1314. #1315

Merged
merged 1 commit into from Sep 24, 2017

Conversation

Projects
None yet
2 participants
@Marsup
Member

Marsup commented Sep 24, 2017

Let me know if it fits your goals @hueniverse.

@Marsup Marsup added the enhancement label Sep 24, 2017

@Marsup Marsup added this to the 11.1.0 milestone Sep 24, 2017

@Marsup Marsup self-assigned this Sep 24, 2017

// or
const promise = Joi.validate(value, schema);
promise.then((value /* { "a" : 123 } */) => {

This comment has been minimized.

@hueniverse

hueniverse Sep 24, 2017

Member

I would put the value example in the payload, not the arguments.

@hueniverse hueniverse merged commit 8b0d898 into master Sep 24, 2017

4 checks passed

Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details

@hueniverse hueniverse deleted the promises branch Sep 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment