Fix object pattern in combination with empty #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidTPate
approved these changes
Dec 22, 2017
|
@Marsup I followed this particular part back and that check has been there since initial inception of pattern matching for object introduced with efc226a. This seems like a semver-minor change as best as I can tell as it is not changing our interface but will slightly change behavior in a very specific edge case. If there's a different opinion I'm definitely open to it. |
|
Thanks @DavidTPate and @choffmeister. I'm indeed tempted not to consider it breaking, it may not even be minor but patch. I'll still release it as minor if people want to pin. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
Joi.object().pattern(...)it is currently not possible to convert values toundefined.I guess the provided test case is self explaining. If not, I am happy to provide a more detailed explanation.