Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloned valid() / invalid() object values #1414

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

kanongil
Copy link
Contributor

This fixes any.valid() and any.invalid() for typeof === 'object' values when used through a method that clones the schema.

Copy link
Contributor

@WesTyler WesTyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I'm not aware of any issues this should cause.

@Marsup Marsup self-assigned this Feb 9, 2018
@Marsup Marsup added the feature New functionality or improvement label Feb 9, 2018
@Marsup Marsup added this to the 13.2.0 milestone Feb 9, 2018
@Marsup Marsup merged commit f20b363 into hapijs:master Feb 9, 2018
@Marsup
Copy link
Collaborator

Marsup commented Feb 9, 2018

Indeed, no idea how it came to be.

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New functionality or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants