Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an object.append() method. Fixes #1381. #1435

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Add an object.append() method. Fixes #1381. #1435

merged 1 commit into from
Mar 9, 2018

Conversation

darknode
Copy link
Contributor

No description provided.

WesTyler
WesTyler suggested changes Feb 14, 2018
View reviewed changes
Copy link
Contributor

@WesTyler WesTyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this add in addition to the existing .keys()?

Also, is there an issue where this addition was discussed? Any details you can add to the PR to give us insight into why this might be useful or necessary?

@WesTyler
Copy link
Contributor

WesTyler commented Feb 14, 2018 •
edited
Loading

tl;dr I don't think this will land. It's a wrapper around .keys().

Got an issue linked, comment no longer stands :)

@darknode
Copy link
Contributor Author

Sorry, issue should be linked by it's id. #1381

@WesTyler
Copy link
Contributor

Ah-ha! Well that certainly changes everything :)

@Marsup Marsup self-assigned this Mar 9, 2018
@Marsup Marsup added the feature New functionality or improvement label Mar 9, 2018
@Marsup Marsup added this to the 13.2.0 milestone Mar 9, 2018
@Marsup Marsup merged commit 35505cb into hapijs:master Mar 9, 2018
@Marsup
Copy link
Collaborator

Marsup commented Mar 9, 2018

Thanks !

@AdriVanHoudt
Copy link
Contributor

This is basically an alias for .keys no?

@Marsup
Copy link
Collaborator

Marsup commented Mar 13, 2018

See linked issue a couple comments above.

@AdriVanHoudt
Copy link
Contributor

So basically, but safer 🙅✨ nice!

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WesTyler WesTyler WesTyler approved these changes

Assignees

@Marsup Marsup

Labels
feature New functionality or improvement
Projects
None yet
Milestone
13.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@darknode @WesTyler @Marsup @AdriVanHoudt