Support ISO8601 with hours timeshift only #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanongil
reviewed
Aug 5, 2020
| @@ -800,6 +800,11 @@ internals.isoDate = function (value) { | |||
| return null; | |||
| } | |||
|
|
|||
| // add missing trailing zeros to timeshift | |||
| if (/.*T.*[+-]\d\d$/.test(value)) { | |||
| value += '00'; | |||
There was a problem hiding this comment.
You need to add the : as well to make it a proper extended iso date string. As it is, it breaks in Safari.
There was a problem hiding this comment.
This PR is already closed and merged into the master and published in v17.2.0.
I think this issue has to become a new ticket now.
| @@ -800,6 +800,11 @@ internals.isoDate = function (value) { | |||
| return null; | |||
| } | |||
|
|
|||
| // add missing trailing zeros to timeshift | |||
| if (/.*T.*[+-]\d\d$/.test(value)) { | |||
There was a problem hiding this comment.
The initial .* is redundant.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2419