Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings on any.external(): add helpers argument #2665

Merged

Conversation

api-haus
Copy link

@api-haus api-haus commented Aug 25, 2021

Since #2455 prefs are passed to external validation as second argument. However, typings had not been updated.

This pr fixes typings for external validation.

Closes #2605

Signed-off-by: Georgy Chirkov <yuri@hello-worlds.com>
@api-haus api-haus force-pushed the issue-2605-helpers-on-external-validation branch from f6f26df to e37613e Compare August 25, 2021 13:39
@api-haus api-haus changed the title Add helpers argument on external validation function Fix typings on any.external(): add helpers argument Aug 26, 2021
@hueniverse hueniverse self-assigned this Dec 1, 2021
@hueniverse hueniverse added bug Bug or defect types TypeScript type definitions labels Dec 1, 2021
@hueniverse hueniverse added this to the 17.5.0 milestone Dec 1, 2021
@hueniverse hueniverse merged commit ad45112 into hapijs:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or defect types TypeScript type definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ExternalValidationFunction" type is missing "helpers" parameter in index.d.ts
2 participants