Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(d.ts): Add type information for maxDomainSegments to EmailOptions and DomainOptions interfaces #2808

Merged
merged 1 commit into from
Sep 18, 2022

Conversation

DaveWoodCom
Copy link
Contributor

Based the comment on the matching code change here: https://github.com/sideway/address/blob/master/src/domain.ts

@Marsup
Copy link
Collaborator

Marsup commented Sep 18, 2022

Thanks!

@Marsup Marsup self-requested a review September 18, 2022 16:19
@Marsup Marsup self-assigned this Sep 18, 2022
@Marsup Marsup added the types TypeScript type definitions label Sep 18, 2022
@Marsup Marsup added this to the 17.6.1 milestone Sep 18, 2022
@Marsup Marsup merged commit eed58e7 into hapijs:master Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types TypeScript type definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants