Fix Joi issue #2746 #2813
Merged
Fix Joi issue #2746 #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martin-petersen
commented
Aug 3, 2022
martin-petersen
commented
- internals.assert was failing in detect empty strings as a message setting this same empty string as options parameter
|
This PR fix issue #2746 |
ramos-ph
reviewed
Aug 4, 2022
martin-petersen
force-pushed
the
joi_issue_2746
branch
2 times, most recently
from
a10f080
to
0e59b3b
Compare
|
The fix looks good, fix the linting issues and we can merge. |
- internals.assert was failing in detect empty strings as a message setting this same empty string as options parameter
Marsup
force-pushed
the
joi_issue_2746
branch
from
e602428
to
04195aa
Compare
Marsup
requested changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.