Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(d.ts)!: type details param of ValidationError constructor #2829

Merged
merged 2 commits into from
Sep 17, 2022
Merged

fix(d.ts)!: type details param of ValidationError constructor #2829

merged 2 commits into from
Sep 17, 2022

Conversation

hekystyle
Copy link
Contributor

Since details property of ValidationError interface is typed as ValidationErrorItem[] then I see no reason why details param of ValidationError constructor should be typed as any.

@hekystyle hekystyle changed the title fix(d.ts)!: strict details param of ValidationError constructor fix(d.ts)!: type details param of ValidationError constructor Sep 9, 2022
@Marsup
Copy link
Collaborator

Marsup commented Sep 17, 2022

I guess that's correct, just needs test fixing.

@Marsup Marsup self-requested a review September 17, 2022 19:04
@Marsup Marsup self-assigned this Sep 17, 2022
@Marsup Marsup added the types TypeScript type definitions label Sep 17, 2022
@hekystyle
Copy link
Contributor Author

@Marsup Test fixed.

@Marsup Marsup merged commit f11bfe1 into hapijs:master Sep 17, 2022
@Marsup
Copy link
Collaborator

Marsup commented Sep 17, 2022

Thanks a lot!

@Marsup Marsup added this to the 17.6.1 milestone Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marsup Marsup Awaiting requested review from Marsup

Assignees

@Marsup Marsup

Labels
types TypeScript type definitions
Projects
None yet
Milestone
17.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@hekystyle @Marsup