Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(d.ts): allow nested object schema for strictly typed object #2836

Merged

Conversation

yarkoyarok
Copy link
Contributor

@yarkoyarok yarkoyarok commented Sep 12, 2022

Fixes #2764

#2785 which fixes same issue seems to be stuck for month after request to add test case. So I am opening this one, with both issue fix and test case, protecting from future degradation.

@yarkoyarok yarkoyarok changed the title fix: allow nested object schema for strictly typed object fix(d.ts): allow nested object schema for strictly typed object Sep 12, 2022
@Marsup Marsup self-assigned this Sep 12, 2022
@Marsup Marsup self-requested a review September 12, 2022 22:43
@Marsup Marsup added bug Bug or defect types TypeScript type definitions labels Sep 12, 2022
@Marsup Marsup added this to the 17.6.1 milestone Sep 17, 2022
@Marsup Marsup merged commit d08ec55 into hapijs:master Sep 17, 2022
@Marsup
Copy link
Collaborator

Marsup commented Sep 17, 2022

I was letting a few days pass to make sure the original pull request didn't move, thanks for picking it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or defect types TypeScript type definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible type expected for object schemas nested in strict object schemas
2 participants