chore: use latest address module #2909
Conversation
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| const Fs = require('fs'); | |||
|
|
|||
| const Assert = require('@hapi/hoek/lib/assert'); | |||
| const Assert = require('@hapi/hoek/assert'); | |||
There was a problem hiding this comment.
@Marsup this broke builds for us after updating our package-locks.json files. this was installed as a transient dependency of another transient dependency package called joi. I have no idea what any of these packages do but this is the error I get when I run unit tests that use the node-jq library:
There was a problem hiding this comment.
The constraint on hoek@^11 is correct though, make sure you upgraded your lockfile properly.
There was a problem hiding this comment.
Oh, wait, you're actually pointing at the benchmarks, why would it even care, it's not even exported by the module.
There was a problem hiding this comment.
ok so that's my bad sorry I chose the wrong file. it's the ....lib/index.js file as seen in the screen shot. I can see that it was changed too. please check #2911 I also opened an issue
so basically when I install the previous version that does not have this PR in it works
| @@ -1,7 +1,7 @@ | |||
| 'use strict'; | |||
|
|
|||
| const Assert = require('@hapi/hoek/lib/assert'); | |||
| const Clone = require('@hapi/hoek/lib/clone'); | |||
| const Assert = require('@hapi/hoek/assert'); | |||
There was a problem hiding this comment.
@Marsup this is the actual line that gives us the error in runtime, sorry for the confusion
Address was rewritten in TypeScript and now includes support for underscores in domains and emails.
Browser bundling had to change a bit because of that.