Path for array includes to contain key #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,6 +40,22 @@ internals.Err.prototype.toString = function () { | |||
| }; | |||
|
|
|||
|
|
|||
| internals.Err.prototype.getPath = function () { | |||
There was a problem hiding this comment.
May want to move this off the prototype and into an internals... otherwise it may be a little odd to have item.path and item.getPath()
There was a problem hiding this comment.
No need to expose this as a new API. Just pass this as an argument.
geek
added a commit
that referenced
this pull request
Aug 27, 2014
Path for array includes to contain key
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior for an array including an object leaves the
pathwithout a key in the object.A message will read correctly:
"message: 'x position 1 fails because x must be a number"While the corresponding path is:
"x.1"This fix changes the path to read:
"x.1.x"which then also matches the error message.This also matches the array behavior with how objects handle the same; where the final key is referenced that has the error occurring.
Assumptions: There will only be one reason so the error will be the first in the array (hence
context.reason.0) . I couldn't find any case where it would be anything else.