Added check for global flag in pattern.

[arb]

If you had /g in your pattern option, the results of pattern.regex.test(key) here will toggle back and forth between true and false creating very unpredictable validation results.

Read up about this design decision http://stackoverflow.com/a/1520853/1011616

I'm not sure what to do about the versioning of this. If you're using a pattern function with "/g" then this is going to break your code.

[geek]

Migration step

Change any global regex pattern to not be global

[hueniverse]

This is the wrong solution.

First, we also need to handle string.regex() which has the same issue. Second, global flag means nothing for validation because it is always called once per string. Instead of a breaking change, it would be better to remove the global flag from the expression, at least for 4.x. We can make a breaking change in 5.x by no longer allowing it.

There is also the sticky flag which I am not even sure how it works. So to be safe, we should always create a new regex and only copy the i flag over.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.