Add format and iso to date type #435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you open a new issue for the bad formats? |
hueniverse
added
bug
Closed
|
Issue opened and docs updated. |
|
I want everything to use the same logic. |
|
OK so after debating with @hueniverse we'll share the code between string and date, and avoid weaker algorithm from moment.js. @rtomlinson consider your pull request merged with this one, sorry for the hijack. @hueniverse ready to merge unless you see other issues. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #428.
Moment.js is more lax about ISO 8601 on a few cases, I kept them commented in the tests so that we don't forget them.
It seems I can't be in strict mode for ISO 8601 otherwise I'd make another test fail (
2013-06-07) so I preferred to switch it off for this case.