Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implements nand #464

Closed
wants to merge 3 commits into from
Closed

implements nand #464

wants to merge 3 commits into from

Conversation

danielb2
Copy link
Contributor

@Marsup
Copy link
Collaborator

Marsup commented Nov 3, 2014

Would you be willing to implement nor as well ?
I think there are a few typos in the readme.

@Marsup Marsup added the feature New functionality or improvement label Nov 3, 2014
@Marsup Marsup added this to the 4.8.0 milestone Nov 3, 2014
@Marsup Marsup self-assigned this Nov 3, 2014
@danielb2
Copy link
Contributor Author

danielb2 commented Nov 3, 2014

Yes, what's the use-case?

Would a not() also make sense then (even more sensible) for when allowUnknown is set?

@Marsup
Copy link
Collaborator

Marsup commented Nov 3, 2014

Now that you mention it, I don't see any, asked in the referenced issue if there was any.
not() is already achieved with any.forbidden().
Can you fix readme ?

@danielb2
Copy link
Contributor Author

danielb2 commented Nov 3, 2014

Fixed grammar issue. Didn't see any typos.

Marsup
Marsup reviewed Nov 3, 2014
View reviewed changes
README.md
@@ -724,6 +725,20 @@ var schema = Joi.object().keys({
}).and('a', 'b');
```

#### `object.nand(peers)`

Defines an relationship between keys where not all peers can be present at the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defines a relationship, sorry for being picky ;)

@danielb2
Copy link
Contributor Author

danielb2 commented Nov 3, 2014

Picky is good. Thanks ;)

@Marsup
Copy link
Collaborator

Marsup commented Nov 4, 2014

Merged, thanks :)

@Marsup Marsup closed this Nov 4, 2014
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Marsup Marsup

Labels
feature New functionality or improvement
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielb2 @Marsup