Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change implementation of creditcard to use string #469

Closed
wants to merge 3 commits into from

Conversation

danielb2
Copy link
Contributor

I did some more research and seems string is in fact the common implementation to use for CC.

@@ -75,6 +74,7 @@ Lead Maintainer: [Eran Hammer](https://github.com/hueniverse)
- [`string.insensitive()`](#stringinsensitive)
- [`string.min(limit, [encoding])`](#stringminlimit-encoding)
- [`string.max(limit, [encoding])`](#stringmaxlimit-encoding)
- [`number.creditCard()`](#stringcreditCard)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string.creditCard()

@cjihrig
Copy link
Contributor

cjihrig commented Oct 31, 2014

👍

@Marsup Marsup added breaking changes Change that can breaking existing code bug Bug or defect labels Nov 3, 2014
@Marsup Marsup added this to the 4.8.0 milestone Nov 3, 2014
@Marsup Marsup removed the breaking changes Change that can breaking existing code label Nov 3, 2014
@Marsup
Copy link
Collaborator

Marsup commented Nov 3, 2014

Merged. Thanks.

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug or defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants