deprecate array.includes and array.excludes, use array.items and allow required and forbidden within #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| description.includes = []; | ||
| var inclusions = [].concat(this._inner.inclusions).concat(this._inner.requireds); |
There was a problem hiding this comment.
concat can take multiple args
Marsup
added
feature
| @@ -88,6 +89,9 @@ internals.checkItems = function (items, wasArray, state, options) { | |||
| var errors = []; | |||
| var errored; | |||
|
|
|||
| var requireds = Hoek.clone(this._inner.requireds); | |||
There was a problem hiding this comment.
please use slice instead, we don't need a deep clone here
nlf
force-pushed
the
array_includes_required
branch
from
99a28e7
to
5daf892
Compare
nlf
changed the title
nlf
force-pushed
the
array_includes_required
branch
from
4327639
to
7dbcc48
Compare
nlf
changed the title
| @@ -422,7 +539,7 @@ describe('array', function () { | |||
|
|
|||
| it('returns an includes array only if includes are specified', function (done) { | |||
|
|
|||
| var schema = Joi.array().includes().max(5); | |||
| var schema = Joi.array().items().max(5); | |||
| var desc = schema.describe(); | |||
| expect(desc.includes).to.not.exist(); | |||
deprecates array.includes and array.excludes allows for use of required() and forbidden() in items list
nlf
force-pushed
the
array_includes_required
branch
from
7dbcc48
to
02d6581
Compare
Marsup
added a commit
that referenced
this pull request
Feb 25, 2015
deprecate array.includes and array.excludes, use array.items and allow required and forbidden within
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is ready now..
array.items()which accepts both.required()and.forbidden()itemsarray.includes()array.excludes()array.describe()output to contain only anitemsarray rather thanincludesandexcludes