Fix allowing context refs on some string, number and date methods #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 23, 2015 13:42
The validation options were not being passed to the validation function. This fixes the number compare functions: min, max, less and greater.
The validation options were not being passed to the validation function. This fixes the string compare functions: min, max and length.
The validation options were not being passed to the validation function. This fixes the date compare functions: min and max.
The validation options were not being passed to the validation function and this merge fixes the following methods when they receive a context ref, e.g, Joi.ref('$a'):
- number: min, max, less and greater
- string: min, max and length
- data: max and min
Marsup
added a commit
that referenced
this pull request
May 23, 2015
Fix allowing context refs on some string, number and date methods
|
Thanks ! |
|
My pleasure. Thank you for the quick merge and publish 👍 |
|
Awesome! 👍 |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoking the following methods:
with e.g. Joi.ref('$a') causes the error:
Cannot read property 'context' of undefinedat lib/ref.js:19:256The validation options where not being passed to the ref validation function, so only normal refs were working, but not context refs.