Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding coverage tests skew the line-numbers in stack statements. #108

Closed
martinheidegger opened this issue Jun 27, 2014 · 3 comments
Labels
bug
Milestone

Comments

@martinheidegger
Copy link
Contributor

@martinheidegger martinheidegger commented Jun 27, 2014

When using lab out of the box with code-coverage enabled and a error occurs it will show the wrong line number (and character number) in the stack trace.

As far as I know this is due to the code generation of the coverage tool. Perhaps this could be solved with code maps enabled? Or by placing the additional statements in a way that as few as possible (zero?) extra lines are introduced? If the statements are strategically placed in the end of lines it would also keep the character number?

@toymachiner62

This comment has been minimized.

Copy link

@toymachiner62 toymachiner62 commented Jul 8, 2014

+1

@hueniverse hueniverse added the bug label Aug 3, 2014
@hueniverse hueniverse added this to the 4.0.0 milestone Aug 3, 2014
@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented Aug 3, 2014

This got broken at some point. Need to fix.

@hueniverse hueniverse closed this in 592c08c Aug 5, 2014
@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented Aug 5, 2014

This fixes line number which was the main issue. Column number still wrong, but less critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.