Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chai #250

Closed
hueniverse opened this issue Oct 16, 2014 · 0 comments · Fixed by #253
Assignees
Milestone

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented Oct 16, 2014

Before we consider bundling lab with a new assertion library, we should remove the existing one. Once we do that, adding a new built-in will be a minor release. By removing it, we ensure a smoother transition as any replacement will include many breaking changes (e.g. no longer using properties for assertsion .exist turns into .exist()).

We should also remove all the custom handling for chai in the reporters. Any such cleanup should happen in the assertion library itself.

@geek geek added this to the 5.0.0 milestone Oct 20, 2014
@hueniverse hueniverse mentioned this issue Oct 22, 2014
@geek geek closed this Oct 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.