Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint option -L should fail test if any linting problems are found #361

Closed
hueniverse opened this issue May 19, 2015 · 2 comments · Fixed by #362
Assignees
Labels
bug
Milestone

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented May 19, 2015

Not sure what's the story with all the --lint extra flags but the default should be the strict case.

@hueniverse hueniverse added the bug label May 19, 2015
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented May 19, 2015

I would also prefer this case, but maybe leave an option in to disable it(not sure why you would but someone is gonna want it)

@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented May 19, 2015

It would probably have broken many projects tests, including ours, but it's a reasonable choice.

Marsup added a commit to Marsup/lab that referenced this issue May 19, 2015
Marsup added a commit to Marsup/lab that referenced this issue May 19, 2015
@geek geek closed this in #362 May 19, 2015
@geek geek added this to the 5.9.0 milestone May 19, 2015
@geek geek self-assigned this May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.