Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-catch-shadow #369

Closed
hueniverse opened this issue Jun 10, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented Jun 10, 2015

@hueniverse hueniverse added the bug label Jun 10, 2015
@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Jun 10, 2015

Variable shadowing is usually a bad practice, catch or not.

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Jun 10, 2015

I agree. Makes the code harder to understand, too.

@hueniverse

This comment has been minimized.

Copy link
Member Author

@hueniverse hueniverse commented Jun 10, 2015

is there a better error than one about IE8?

@geek

This comment has been minimized.

Copy link
Member

@geek geek commented Jun 10, 2015

We can use https://jslinterrors.com/a-is-already-defined instead, it accomplishes the same thing.

@geek geek self-assigned this Jun 10, 2015
@geek geek added this to the 5.10.1 milestone Jun 10, 2015
@geek geek added feature and removed bug labels Jun 10, 2015
@hueniverse

This comment has been minimized.

Copy link
Member Author

@hueniverse hueniverse commented Jun 10, 2015

wfm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.