Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document html coverage report source markup #439

Closed
skeggse opened this issue Sep 13, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@skeggse
Copy link
Contributor

@skeggse skeggse commented Sep 13, 2015

I'm new to lab, having spent some time with istanbul. Istanbul's html coverage reporter annotates what branches and conditions have been visited, and includes tooltips that indicate things like "branch not covered" and "statement not covered." The colors that istanbul uses make it easy to understand what the tests aren't covering.

I'm not finding the same to be true for lab. Different parts of isemail are being highlighted in grey-green and light-green, and don't include any explanatory text. They appear in seemingly the same contexts, but I can't get them to go away by adding what I think is the appropriate tests.

Could we document what the colors mean/add explanatory text in perhaps the form of a tooltip (title attribute) to make this clearer?

@geek geek added the request label Sep 13, 2015
@geek

This comment has been minimized.

Copy link
Member

@geek geek commented Sep 13, 2015

@skeggse very good point. Here is where the colors are determined at the moment: https://github.com/hapijs/lab/blob/master/lib/reporters/html/report.html#L314

@skeggse

This comment has been minimized.

Copy link
Contributor Author

@skeggse skeggse commented Sep 13, 2015

I found that, but I'm not sure what the different classes mean - what is a .miss.false vs a .miss.true?

@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Sep 14, 2015

This means the condition was always either true or false, need both to have proper coverage.

@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Sep 19, 2015

Not to waste anyone's time, I'm working on it currently with other features I'd want in.

@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Sep 22, 2015

Closed by above PR.

@Marsup Marsup closed this Sep 22, 2015
@Marsup Marsup added this to the 5.18.0 milestone Sep 22, 2015
@Marsup Marsup added feature and removed request labels Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.