Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint warning for unused variables except internals #453

Closed
hueniverse opened this issue Sep 25, 2015 · 3 comments
Closed

Lint warning for unused variables except internals #453

hueniverse opened this issue Sep 25, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented Sep 25, 2015

No description provided.

@hueniverse hueniverse added the request label Sep 25, 2015
@cjihrig

This comment has been minimized.

Copy link
Contributor

@cjihrig cjihrig commented Sep 26, 2015

I published v3.0.0 of eslint-config-hapi. I was about to make a PR to lab, but there are a lot of warnings. Most of them refer to unused function arguments, for example - https://github.com/hapijs/lab/blob/master/lib/reporters/lcov.js#L23

@geek

This comment has been minimized.

Copy link
Member

@geek geek commented Sep 26, 2015

I think unused function arguments should be excluded from the check. While an unused argument can be removed, they also help document the expected arguments.

@hueniverse

This comment has been minimized.

Copy link
Member Author

@hueniverse hueniverse commented Sep 26, 2015

I agree. Unused function arguments are not a problem but the right way to write code. If you implement a callback you should include all the arguments expected as a way to document the interface.

@geek geek added this to the 6.0.0 milestone Sep 26, 2015
@geek geek self-assigned this Sep 26, 2015
@geek geek added the feature label Sep 26, 2015
@geek geek closed this Sep 27, 2015
@Marsup Marsup removed the request label Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.