Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upconsider testing arg passed to done is an error object #475
Comments
This comment has been minimized.
This comment has been minimized.
Perhaps it could error if the argument is not an error object in a way that insists that an error object be passed. |
This comment has been minimized.
This comment has been minimized.
To not suddenly let builds pass that use this I would like @devinivy said, error with a message to use an error and maybe also print what was passed |
This comment has been minimized.
This comment has been minimized.
@AdriVanHoudt and @devinivy sounds like a good plan to me |
This comment has been minimized.
This comment has been minimized.
Fixed by 35cf424 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
currently as the documentation states
I feel like this should be slightly more restrictive and also require that an argument passed to
done()
be an instance of Error.As it is currently, if you pass a non-Error object to done, the reporter prints nothing. For example:
displays the following:
which is completely unhelpful. we should either print whatever was passed, or only error if the argument is an error object.