Skip to content

/lab

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hapijs/items to 2.0.0 from 1.1.1 #479

Closed
hueniverse opened this issue Oct 31, 2015 · 4 comments
Assignees
@geek
Labels
dependency
Milestone
8.0.0

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented Oct 31, 2015

No description provided.

@AdriVanHoudt

This comment has been minimized.

Sign in to view
Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Oct 31, 2015

missed a space in the title ;)
@hueniverse hueniverse changed the title Update hapijs/itemsto 2.0.0 from 1.1.1 Update hapijs/items to 2.0.0 from 1.1.1 Oct 31, 2015
@geek

This comment has been minimized.

Sign in to view
Copy link
Member

@geek geek commented Nov 4, 2015

@hueniverse thoughts on switching to https://www.npmjs.com/package/fastparallel which is faster than items and also a v2 ?
@hueniverse

This comment has been minimized.

Sign in to view
Copy link
Member Author

@hueniverse hueniverse commented Nov 4, 2015

Hmm. For lab I really don't care. This module already comes with a gigantic pile of crap. For hapi I need to study it closer. When we first wrote items it was equal in performance to async. Looks like it got slower now (or others got faster). If the code looks good, I'll see if we should borrow the code we need or just switch over.
@devinivy

This comment has been minimized.

Sign in to view
Copy link
Member

@devinivy devinivy commented Nov 4, 2015

Would we continue to use items for serial calls, or move to fastserial? I personally really like the simplicity of the implementation/API of items, and would prefer to adapt it slightly if we could get comparable speed.
@geek geek mentioned this issue Nov 24, 2015
Merged
@geek geek added this to the 7.3.1 milestone Nov 24, 2015
@geek geek self-assigned this Nov 24, 2015
@geek geek closed this in #492 Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geek geek

Labels
dependency
Projects
None yet
Milestone
  8.0.0
4 participants
@hueniverse @AdriVanHoudt @geek @devinivy
You can’t perform that action at this time.