Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage reporting does not support parsing ES6 objectLiteralComputedProperties #491

Closed
alobodig opened this issue Nov 23, 2015 · 3 comments
Closed
Assignees
Labels
Milestone

Comments

@alobodig
Copy link
Contributor

@alobodig alobodig commented Nov 23, 2015

The configuration options object passed to espree (in lib/coverage.js) does not have objectLiteralComputedProperties set to true, but does have some other ES6 parsing options set. Would it be possible to provide a way to set other parsing options from outside of lab?

@geek geek added the request label Nov 29, 2015
@geek

This comment has been minimized.

Copy link
Member

@geek geek commented Nov 29, 2015

I am open to the change to pass options in, for now, feel free to create a PR to enable objectLiteralComputedProperties

@jedireza

This comment has been minimized.

Copy link
Contributor

@jedireza jedireza commented Jan 17, 2016

This can be closed right?

@alobodig

This comment has been minimized.

Copy link
Contributor Author

@alobodig alobodig commented Jan 18, 2016

Yes, it can. Thanks.

On Sun, Jan 17, 2016 at 2:12 PM, Reza Akhavan notifications@github.com
wrote:

This can be closed right?


Reply to this email directly or view it on GitHub
#491 (comment).

@Marsup Marsup added this to the 8.0.0 milestone Jan 18, 2016
@Marsup Marsup closed this Jan 18, 2016
@Marsup Marsup added feature and removed request labels Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.