Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaks detected:Reflect using node v6.0.0 #568

Closed
cpilsworth opened this issue Apr 27, 2016 · 4 comments
Closed

leaks detected:Reflect using node v6.0.0 #568

cpilsworth opened this issue Apr 27, 2016 · 4 comments
Assignees
Labels
bug
Milestone

Comments

@cpilsworth
Copy link

@cpilsworth cpilsworth commented Apr 27, 2016

When running a lab test with v6.0.0 with the latest Lab (v10.3.1), I get the following message:

$ node --version
v6.0.0
$ npm --version
3.8.6
$ nvm --version
0.31.0

The following leaks were detected:Reflect
(node:2983) DeprecationWarning: 'root' is deprecated, use 'global'
npm ERR! Test failed.  See above for more details.

Works with all 4.x.x, 5.x.x versions of Node.

The failing build can be found here:
https://travis-ci.org/cpilsworth/aws-s3-signurl/jobs/126106138
and a working build here:
https://travis-ci.org/cpilsworth/aws-s3-signurl/jobs/126106139

@cpilsworth cpilsworth changed the title The following leaks were detected:Reflect leaks detected:Reflect using node v6.0.0 Apr 27, 2016
@cpilsworth

This comment has been minimized.

Copy link
Author

@cpilsworth cpilsworth commented Apr 27, 2016

Updated dependencies to "lab": "hapijs/lab#master" and the problem persists

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Apr 27, 2016

Master is the published version on this repo.

The hapi modules have not been updated to work with v6 (hapi modules officially supports 0.12 in LTS mode and 4 I think) and this could take some time. In the meanwhile if you want to speed this up I'm sure they will appreciate any help/PR!

@geek geek closed this in #569 Apr 27, 2016
@geek geek added the bug label Apr 27, 2016
@geek geek added this to the 10.3.2 milestone Apr 27, 2016
@geek geek self-assigned this Apr 27, 2016
@geek

This comment has been minimized.

Copy link
Member

@geek geek commented Apr 27, 2016

@cpilsworth this is now published and everything is working in node v6 with version 10.3.2 of lab. Thanks for the PR and issue!

@cpilsworth

This comment has been minimized.

Copy link
Author

@cpilsworth cpilsworth commented Apr 27, 2016

np. @gergoerdosi did the good work on the PR. Thanks for merging so quickly!

emilio-martinez added a commit to emilio-martinez/stencil-styles that referenced this issue Feb 20, 2017
The version of `lab` stated in the devDependencies did not support `node 6`. Running the tests would throw an error of `The following leaks were detected:Reflect`. On `lab 10.3.2`, `node 6` support is added and `Reflect` is added to the globals whitelist, fixing that error (see hapijs/lab#568).

Upgrading `lab` and `code` to their latest major versions.
emilio-martinez added a commit to emilio-martinez/stencil-styles that referenced this issue Feb 22, 2017
The version of `lab` stated in the devDependencies did not support `node 6`. Running the tests would throw an error of `The following leaks were detected:Reflect`. On `lab 10.3.2`, `node 6` support is added and `Reflect` is added to the globals whitelist, fixing that error (see hapijs/lab#568).

Upgrading `lab` and `code` to their latest major versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.