Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to eslint@2.13.x #610

Closed
feugy opened this issue Jun 24, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@feugy
Copy link
Contributor

@feugy feugy commented Jun 24, 2016

Currently lab uses eslint@2.10.x, and it took 27s to process my sources.
With eslint@2.13.x, it took only 3s

This is due to 2.12 improvement that do not walk into ignored folders (like huge node_modules)

Please, save our lives 馃榾

@cjihrig

This comment has been minimized.

Copy link
Contributor

@cjihrig cjihrig commented Jun 24, 2016

Why not open a PR and save our lives 馃槃

lloydbenson added a commit to lloydbenson/lab that referenced this issue Jun 24, 2016
@geek geek added the dependency label Jun 24, 2016
@geek geek self-assigned this Jun 24, 2016
@geek geek added this to the 10.8.3 milestone Jun 24, 2016
@cjihrig

This comment has been minimized.

Copy link
Contributor

@cjihrig cjihrig commented Jun 24, 2016

Nevermind. @lloydbenson is a life saver!

@geek geek closed this in 1fafc20 Jun 24, 2016
@feugy

This comment has been minimized.

Copy link
Contributor Author

@feugy feugy commented Jun 25, 2016

You guys are awesome ! Thanks a million
(It was late yesterday, and I wasn't brave enought to fork and send a PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.